tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-qca6390-mhi head: dc3ad30e8022e5f833d4ae26935f03aff6d1f733 commit: 2836722907d15b06d3e3ce9339f9f3cb2ab5da4e [36/48] ath11k: enable second mac related ring setup reproduce: # apt-get install sparse # sparse version: v0.6.1-129-g341daf20-dirty git checkout 2836722907d15b06d3e3ce9339f9f3cb2ab5da4e make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag Reported-by: kbuild test robot <[email protected]> sparse warnings: (new ones prefixed by >>) >> drivers/net/wireless/ath/ath11k/dp_rx.c:332:17: sparse: sparse: incorrect >> type in assignment (different base types) drivers/net/wireless/ath/ath11k/dp_rx.c:332:17: sparse: expected struct dp_rxdma_ring *rx_ring drivers/net/wireless/ath/ath11k/dp_rx.c:332:17: sparse: got struct dp_rxdma_ring ( * )[1] vim +332 drivers/net/wireless/ath/ath11k/dp_rx.c d5c65159f28953 Kalle Valo 2019-11-23 306 d5c65159f28953 Kalle Valo 2019-11-23 307 static int ath11k_dp_rxdma_buf_ring_free(struct ath11k *ar, d5c65159f28953 Kalle Valo 2019-11-23 308 struct dp_rxdma_ring *rx_ring) d5c65159f28953 Kalle Valo 2019-11-23 309 { 2836722907d15b Carl Huang 2019-12-12 310 #ifdef CONFIG_ATH11K_AHB d5c65159f28953 Kalle Valo 2019-11-23 311 struct ath11k_pdev_dp *dp = &ar->dp; 2836722907d15b Carl Huang 2019-12-12 312 #endif d5c65159f28953 Kalle Valo 2019-11-23 313 struct sk_buff *skb; d5c65159f28953 Kalle Valo 2019-11-23 314 int buf_id; d5c65159f28953 Kalle Valo 2019-11-23 315 d5c65159f28953 Kalle Valo 2019-11-23 316 spin_lock_bh(&rx_ring->idr_lock); d5c65159f28953 Kalle Valo 2019-11-23 317 idr_for_each_entry(&rx_ring->bufs_idr, skb, buf_id) { d5c65159f28953 Kalle Valo 2019-11-23 318 idr_remove(&rx_ring->bufs_idr, buf_id); d5c65159f28953 Kalle Valo 2019-11-23 319 /* TODO: Understand where internal driver does this dma_unmap of d5c65159f28953 Kalle Valo 2019-11-23 320 * of rxdma_buffer. d5c65159f28953 Kalle Valo 2019-11-23 321 */ d5c65159f28953 Kalle Valo 2019-11-23 322 dma_unmap_single(ar->ab->dev, ATH11K_SKB_RXCB(skb)->paddr, d5c65159f28953 Kalle Valo 2019-11-23 323 skb->len + skb_tailroom(skb), DMA_FROM_DEVICE); d5c65159f28953 Kalle Valo 2019-11-23 324 dev_kfree_skb_any(skb); d5c65159f28953 Kalle Valo 2019-11-23 325 } d5c65159f28953 Kalle Valo 2019-11-23 326 d5c65159f28953 Kalle Valo 2019-11-23 327 idr_destroy(&rx_ring->bufs_idr); d5c65159f28953 Kalle Valo 2019-11-23 328 spin_unlock_bh(&rx_ring->idr_lock); d5c65159f28953 Kalle Valo 2019-11-23 329 2836722907d15b Carl Huang 2019-12-12 330 //below code seems very buggy as double free. 2836722907d15b Carl Huang 2019-12-12 331 #ifdef CONFIG_ATH11K_AHB d5c65159f28953 Kalle Valo 2019-11-23 @332 rx_ring = &dp->rx_mon_status_refill_ring; d5c65159f28953 Kalle Valo 2019-11-23 333 d5c65159f28953 Kalle Valo 2019-11-23 334 spin_lock_bh(&rx_ring->idr_lock); d5c65159f28953 Kalle Valo 2019-11-23 335 idr_for_each_entry(&rx_ring->bufs_idr, skb, buf_id) { d5c65159f28953 Kalle Valo 2019-11-23 336 idr_remove(&rx_ring->bufs_idr, buf_id); d5c65159f28953 Kalle Valo 2019-11-23 337 /* XXX: Understand where internal driver does this dma_unmap of d5c65159f28953 Kalle Valo 2019-11-23 338 * of rxdma_buffer. d5c65159f28953 Kalle Valo 2019-11-23 339 */ d5c65159f28953 Kalle Valo 2019-11-23 340 dma_unmap_single(ar->ab->dev, ATH11K_SKB_RXCB(skb)->paddr, d5c65159f28953 Kalle Valo 2019-11-23 341 skb->len + skb_tailroom(skb), DMA_BIDIRECTIONAL); d5c65159f28953 Kalle Valo 2019-11-23 342 dev_kfree_skb_any(skb); d5c65159f28953 Kalle Valo 2019-11-23 343 } d5c65159f28953 Kalle Valo 2019-11-23 344 d5c65159f28953 Kalle Valo 2019-11-23 345 idr_destroy(&rx_ring->bufs_idr); d5c65159f28953 Kalle Valo 2019-11-23 346 spin_unlock_bh(&rx_ring->idr_lock); 2836722907d15b Carl Huang 2019-12-12 347 #endif d5c65159f28953 Kalle Valo 2019-11-23 348 return 0; d5c65159f28953 Kalle Valo 2019-11-23 349 } d5c65159f28953 Kalle Valo 2019-11-23 350 :::::: The code at line 332 was first introduced by commit :::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices :::::: TO: Kalle Valo <[email protected]> :::::: CC: Kalle Valo <[email protected]> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/[email protected] Intel Corporation _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
