On Mon, Apr 14, 2025 at 10:27 AM Thomas Weißschuh
<thomas.weisssc...@linutronix.de> wrote:
>
> In the past %pK was preferable to %p as it would not leak raw pointer
> values into the kernel log.
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
> the regular %p has been improved to avoid this issue.
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through printk(). They can still unintentionally leak raw pointers or
> acquire sleeping looks in atomic contexts.
>
> Switch to the regular pointer formatting which is safer and
> easier to reason about.
> There are still a few users of %pK left, but these use it through seq_file,
> for which its usage is safe.
>
> Signed-off-by: Thomas Weißschuh <thomas.weisssc...@linutronix.de>Acked-by: Loic Poulain <loic.poul...@oss.qualcomm.com> > --- > drivers/net/wireless/ath/wcn36xx/testmode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/testmode.c > b/drivers/net/wireless/ath/wcn36xx/testmode.c > index > e5142c052985ddf629b93d7b9687e6ba63a48e8b..d7a2a483cbc486308032709a99bba9a52ed0ff59 > 100644 > --- a/drivers/net/wireless/ath/wcn36xx/testmode.c > +++ b/drivers/net/wireless/ath/wcn36xx/testmode.c > @@ -56,7 +56,7 @@ static int wcn36xx_tm_cmd_ptt(struct wcn36xx *wcn, struct > ieee80211_vif *vif, > msg = buf; > > wcn36xx_dbg(WCN36XX_DBG_TESTMODE, > - "testmode cmd wmi msg_id 0x%04X msg_len %d buf %pK > buf_len %d\n", > + "testmode cmd wmi msg_id 0x%04X msg_len %d buf %p buf_len > %d\n", > msg->msg_id, msg->msg_body_length, > buf, buf_len); > > > -- > 2.49.0 > >
