On Tue, Mar 2, 2010 at 10:42 AM, Jouni Malinen <j...@w1.fi> wrote: > On Tue, Mar 02, 2010 at 11:51:58AM +0900, Bruno Randolf wrote: >> injected frames have to use AR5K_PKT_TYPE_NORMAL, otherwise the hardware >> thinks >> it can mess with the contents of the frame - e.g. update the TSF of an >> injected >> beacon. injected frames should be sent as they are provided. > > Why would we never want the hardware to update fields in injected > frames? Unless I missed something, this seems to break hostapd use cases > where the hardware is indeed expected to update the timestamp in Probe > Response frames and set up seq# and duration etc. as appropriate for the > frames (the latter may be driver/mac80211 work; the timestamp needs to > come from hardware/firmware). > > If we want to have an option to prevent hardware from touching the frame > payload, that really should be an option (a radiotap and TX control > flags, etc.), not default functionality for monitor interface. The use > case for this seems to be some kind of testing purpose and that should > not really break more common functionality. > > >> + /* we don't want the hardware to mess with injected frames in monitor >> + * mode (e.g. update TSF in beacons) */ >> + if (info->flags & IEEE80211_TX_CTL_INJECTED) >> + pkt_type = AR5K_PKT_TYPE_NORMAL; > > This is the part I object to. IEEE80211_TX_CTL_INJECTED should not be > used for this. >
Umm... what should be used, then? A check for monitor mode? That's even more wrong... > -- > Jouni Malinen PGP id EFC895FA > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
