On Fri, Apr 16, 2010 at 12:12:09PM +0900, Bruno Randolf wrote: > hello! > > we have found the this suspect piece of code in ath5k_hw_reset(): > > /* Note: According to docs we can have a newer > * EEPROM on old hardware, so we need to verify > * that our hardware is new enough to have spur > * mitigation registers (delta phase etc) */ > if (ah->ah_mac_srev >= AR5K_SREV_AR5424 || > (ah->ah_mac_srev >= AR5K_SREV_AR5424 && > ee->ee_version >= AR5K_EEPROM_VERSION_5_3)) > ath5k_hw_set_spur_mitigation_filter(ah, > channel); > > logically this does not make sense - it's the same as > > if (ah->ah_mac_srev >= AR5K_SREV_AR5424) > > right? did we miss something? what was the intention of this code?
Madwifi has this: if (IS_5413(ah) || (AH_PRIVATE(ah)->ah_eeversion >= AR_EEPROM_VER5_3)) My guess from the comment is it started out similarly but the other clause was added because someone had an earlier chip with a newer eeprom? -- Bob Copeland %% www.bobcopeland.com _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
