On Sat, Jun 11, 2011 at 12:42 PM, Adrian Chadd <adr...@freebsd.org> wrote:
> ok. Mohammed, APSM is broken in a different way on some laptops. maybe
> the state transition between sleep states is different somehow.
>
> Which model notebook is this Camilo? :)
>
>
> adrian
>
> On 11 June 2011 14:42, Camilo Mesias <cam...@mesias.co.uk> wrote:
>> Hi,
>>
>> On Fri, Jun 10, 2011 at 5:10 PM, Adrian Chadd <adr...@freebsd.org> wrote:
>>> On 11 June 2011 02:47, Tony Houghton <h...@realh.co.uk> wrote:
>> [...]
>>>>> Let's just try the patch I emailed you to apply to wireless-testing.
>>>>> Hopefully that restores functionality enough and we can punt it to the
>>>>> Atheros guys to do some further investigation.
>>>>
>>>> That change seems to have fixed it! I've managed at least 3
>>>> suspend/resumes and an rmmod/modprobe without crashing. Perhaps a little
>>>> early to say it's definitely fixed, but I don't think I've ever managed
>>>> more than 2 attempts in a row without a "bad" version crashing.
>>>
>>> Excellent! Let's see if it fixes it for other users.
>>> Camilo? :)
>>
>> I had some problems with the wireless-testing software but managed to
>> rebuild the current kernel from source (2.6.38.7-30.fc15.i686) then
>> commented out the relevant driver part and changed the
>> AR9285_WA_DEFAULT value too. I made sure I was running the rebuilt
>> modules and... it works. I suspended and resumed just fine.
>>
>> I'm not sure how I can quickly get a clean fix, I think this might be
>> tweakable with the patch:
>>
>> http://people.redhat.com/sgruszka/compact_wireless.html
>>
>> Or I could just stay on my bodged kernel for a while (although this
>> doesn't help anyone else)
>>
>> Thanks for all the help, it looks like my netbook is useful again :D
I had removed a check that looks redundant. this will be anyway called
in radio_disable.
if some one has time and has easy way of applying the patch like in
compat wireless, can they see if it fixes by any chance(less
probably).
FYI I had gone through the pcipowersave module itself and did not find
any obvious deviation apart from some junk work around that need to be
done for AR9285E which does not seems to be related to this
diff --git a/drivers/net/wireless/ath/ath9k/main.c
b/drivers/net/wireless/ath/ath9k/main.c
index 7f94533..e7f8ef2 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1259,7 +1259,6 @@ static void ath9k_stop(struct ieee80211_hw *hw)
/* disable HAL and put h/w to sleep */
ath9k_hw_disable(ah);
- ath9k_hw_configpcipowersave(ah, 1, 1);
spin_unlock_bh(&sc->sc_pcu_lock);
>>
>> -Cam
>>
>
--
shafi
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 7f94533..e7f8ef2 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1259,7 +1259,6 @@ static void ath9k_stop(struct ieee80211_hw *hw)
/* disable HAL and put h/w to sleep */
ath9k_hw_disable(ah);
- ath9k_hw_configpcipowersave(ah, 1, 1);
spin_unlock_bh(&sc->sc_pcu_lock);
_______________________________________________
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
