Am 28.04.2013 14:51, schrieb Felix Fietkau: > On 2013-04-27 5:25 PM, Oleksij Rempel wrote: >> Collect statistics about recived duplicate and STBC packets. >> This information should help see if STBC is actually working. >> >> Tested on ar9285; >> >> Signed-off-by: Oleksij Rempel <li...@rempel-privat.de> > I thought about this patch some more, and I'm wondering what's the point > in doing this? These statistics are going to be completely useless for > most people and they'll waste some memory/cpu cycles, especially on > small-cache devices. I think it's much more useful to simply pass the > information to mac80211 via rx flags and get them added to the radiotap > header.
Sure. > I'd like to keep the number of 'poor man's debug hacks' in the driver to > a minimum, well, i'll prefer it to call with my name: lazy man's hack ;) > and there are some other things that I think should be > removed: rx_frags and rx_beacons in struct ath_rx_stats, the tx/rx MAC > sampling hack, and pretty much anything else that can be just as easily > accessed from mac80211 through regular interfaces. I think there is more things to do in ath9k. Create the list and we can talk about it. For example one of it: I needed some time to understand how some parts of code relate to the hardware. Especially Rx and Tx descriptors. Some comments in header will help... I can add some of them (may be it will help other beginners), but i afraid that i spend time but my patches wont be included. -- Regards, Oleksij _______________________________________________ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
