Hi Ralf, 2013/7/19 Ralf Angeli <[email protected]>: > * Tassilo Horn (2013-07-19) writes: > >> Mosč Giordano <[email protected]> writes: >> >>> Please triple check the patch, if it's ok I'll push it. > > Here are a few points that caught my eye: > > -COMMITTER="David Kastrup <[email protected]>" > +COMMITTER="`git config user.name` \<`git config user.email`\>" > > Those two commands return nothing if I execute them on the command line. > I'm a git novice, so I might have misconfigured it. But at least `git > pull' works. (c:
If those `git config' commands return nothing then you can pass
`COMMITTER' values as a command line argument, as usual. To setup
those keys run
git config --global user.name "John Doe"
git config --global user.email [email protected]
However, probably it's safer to obtain keys values with `--get' option.
> - echo `date "+%Y-%m-%d "`" "${COMMITTER} > ChangeLog
> + echo `date "+%Y-%m-%d "`" ${COMMITTER}" > ChangeLog
>
> Not sure if this change is necessary.
Without this change I previously got a redirection error due to the
`<..>' in `COMMITTER' value, but testing again the error is gone :-S
> - cvs commit -m 'Release_$(TAG)' ChangeLog
> - cvs tag release_`echo $(TAG) | sed -e 's/[.]/_/g'`
> + git add ChangeLog
>
> Again, I don't know git very well. Is `git add' necessary because the
> old ChangeLog file was moved before?
>
> + git commit -m 'Release_$(TAG)'
>
> Does that only commit the ChangeLog file like the old `cvs commit' call?
`git add file' stages `file' for the next commit, then `git commit'
actually commits all staged files. So `git add ChangeLog ; git
commit' should be equivalent to `cvs commit ChangeLog'. `git commit
-a' commits all tracked files, also non explicitly staged ones, but I
don't think it's a good idea to use it.
> + git tag release_`echo $(TAG) | sed -e 's/[.]/_/g'`
> + rm ChangeLog.old
>
> If you want to delete the old ChangeLog file is probably a matter of
> taste. When something goes wrong you'd have to edit the new ChangeLog
> file and cannot just move the old one back in place.
Ok, I'll remove the `rm', but you can bring back the previous
ChangeLog with `git checkout HEAD^ ChangeLog'.
> - cvs export -d auctex-$(TAG) \
> - `echo $${TAG_EXPORT:=$(TAG)} | \
> + git archive `echo $${TAG_EXPORT:=$(TAG)} | \
> sed -e '/^\([-0-9]*[0-9]\)[-a-z]*$$/s//-D \1/' \
> - -e '/[.]/{s/^/-r release_/;s/[.]/_/g}'` auctex
> - cd auctex-$(TAG) && AUCTEXVERSION=$(TAG) AUCTEXDATE=$(AUCTEXDATE)
> ./autogen.sh && rm $(CVSFILES)
> + -e '/[.]/{s/^/release_/;s/[.]/_/g}'` | tar -xC auctex-$(TAG)
>
> The call seems to work for release_... tags but it does not work for
> cases where TAG_EXPORT is set because `git archive' does not recognize a
> -D switch. Reiner had been using this for generating snapshots. In the
> following message is an example:
>
> <URL:http://article.gmane.org/gmane.emacs.auctex.devel/1320>
>
> I'm not sure if it is still being used. If not, we could get rid of it.
> Reiner?
>
> - cvs export -d $(PREVIEW_BUILD_DIR) \
> - `echo $${TAG_EXPORT:=$(TAG)} | \
> + git archive `echo $${TAG_EXPORT:=$(TAG)} | \
> sed -e '/^\([-0-9]*[0-9]\)[-a-z]*$$/s//-D \1/' \
> - -e '/[.]/{s/^/-r release_/;s/[.]/_/g}'` auctex/preview/latex
> + -e '/[.]/{s/^/release_/;s/[.]/_/g}'` preview/latex | tar \
> + -xC $(PREVIEW_BUILD_DIR) --strip-components=2
>
> There's likely the same problem here.
One can get the commit hash for a specific date with
git rev-list -n 1 --until=<date> master
and use it as `TAG_EXPORT'.
The attached patch should fix the problems you pointed out. Other
comments? Thanks for your suggestions!
Bye,
Mosè
git-release.patch
Description: Binary data
_______________________________________________ auctex-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/auctex-devel
