> Hi Uwe,
> 2016-08-13 16:06 GMT+02:00 Uwe Brauer <[email protected]>:
> Thank you for your contribution. A few comments:
> 1) first of all, did you sign the copyright papers? We can't accept
> this file before you do so
Not yet, I wanted to be sure that the contribution turns out to be
useful. I have received the forms though. I will sign send and report
once the process is finished.
> 2) did you start writing this style file in 2003? In addition, I
> don't think the file was created in 20153 ;-)
oh
> 3) `LaTeX-add-environments' syntax is
> (LaTeX-add-environments &rest ENVIRONMENTS)
> so you don't need multiple calls to the function.
ok
> 4) "question" macro is repeated three times
ok
> 5) `reftex-label' is a RefTeX function, but AUCTeX is independent from
> RefTeX. Use `TeX-arg-label' instead (when RefTeX is installed and
> `reftex-plug-into-AUCTeX' is non-nil, `TeX-arg-label' is aliased
> to`reftex-arg-label')
ok
> 6) actually, these environments are itemize-like, so you may want to
> use features related to `LaTeX-insert-item' and `LaTeX-item-list'
ok
> 7) in general, do not use hard-coded "[", we have much more advanced
> functions to insert arguments, see `TeX-argument-insert'. However, in
> this case `TeX-arg-examn-points' is useless, "[ "Points" ]" (without
> outer quotes) works just fine, like you did in the last definition of
> "question".
ok
Thanks for your comments. Two questions:
- is a mercurial patch ok?
- shall I also modify the Makefile?
Uwe
_______________________________________________
auctex-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/auctex-devel
