Hi Al,

>>>>> Al Haji-Ali <[email protected]> writes:
> I tried to follow your suggestions and the GNU guidelines and pushed
> the changes to my public repo (https://github.com/haji-ali/auctex).

Thank you.

> I don't know what would be easier at this stage, if you want you can
> inspect the changes in my repo to suggest further changes.

I'd like to request to make the first line of the doc string of
`TeX--master-output-dir' and `TeX--output-dir-arg' not end in the middle
of the sentence.

And please apply the attached patch to make lines not too long.

I think it's ready to incorporate your work into AUCTeX after those.
Tassilo, what is the best way to do that? Just merging
origin/tex-build-only to master branch? Or should we ask Al to make a
single integrated patch and git commit message along with it?

Regards,
Ikumi Keita

--- preview.el.in~	2021-03-15 17:05:55.403060000 +0900
+++ preview.el.in	2021-03-15 17:13:25.931873000 +0900
@@ -3156,7 +3156,8 @@
                 0))
     (shell-quote-argument
      (concat (file-name-as-directory
-              ;; Don't use topdir, because %m expects the path to be relative to master
+              ;; Don't use topdir, because %m expects the path to be
+              ;; relative to master
               (TeX-active-master "prv" t))
              (file-name-nondirectory (nth 0 TeX-active-tempdir))))))
 
@@ -4162,10 +4163,12 @@
       ((preview-format-name (shell-quote-argument
                              (concat "&"
                                      (preview-dump-file-name
-                                      ;; Get the filename from TeX-master-file with prv
-                                      ;; to get the correct path but then strip
-                                      ;; the extension
-                                      (file-name-sans-extension (TeX-master-file "prv" t))))))
+                                      ;; Get the filename from
+                                      ;; `TeX-master-file' with prv to
+                                      ;; get the correct path but then
+                                      ;; strip the extension
+                                      (file-name-sans-extension
+				       (TeX-master-file "prv" t))))))
        (process-environment (copy-sequence process-environment))
        (process
         (progn

Reply via email to