On Fri, Nov 10 2006, David Kastrup wrote: > Reiner Steib <[EMAIL PROTECTED]> writes: >> --8<---------------cut here---------------start------------->8--- >> --- toolbar-x.el 25 May 2006 07:50:57 -0000 1.12 >> +++ toolbar-x.el 13 Sep 2006 20:15:00 -0000 1.13 >> @@ -1322,7 +1322,8 @@ >> toolbarx-internal-button-switches)) >> (used-keys (list :used-symbols nil)) >> (tool-bar-map-temp)) >> - (let ((tool-bar-map (make-sparse-keymap))) >> + (let (tool-bar-map) >> + (set (make-local-variable 'tool-bar-map) (make-sparse-keymap)) > > Eek. That can't be right.
I never claimed that my changes is the right thing to do (therefore I asked on auctex-devel): ,----[ http://thread.gmane.org/v98xknj3dd.fsf%40marauder.physik.uni-ulm.de ] | I noticed that when visiting some LaTeX files (during the last weeks), | the global tool bar got empty or vanished completely in non-LaTeX | buffers. It is extremely annoying then you hit `C-c C-c' because the | Emacs frame shrinks as shown in the frames with a yellow background in | the attached screen shot. The problem occurred when LaTeX files were | involved. | | I found out that the global value of `tool-bar-map' is (keymap) in | such a situation, which is what `make-sparse-keymap' returns. I | suspect that at least one use of `make-sparse-keymap' in | `toolbar-x.el' is wrong. Apparently `toolbar-x.el' modifies the | _global_ value of `tool-bar-map'. The following patch seems to fix | this problem. I'll commit it unless someone points out a problem with | this or offers a better solution. `---- > The previous version did not modify any global value of > tool-bar-map, but made a local let-binding. I'm quite sure that the previous version was not correct (maybe the problem is not at this spot): Before the change, I saw the problem with vanishing tool bar both in Emacs 22 and Emacs 21 (used by my colleagues). After my patch I never saw the problem again. > The changed version first creates a let-binding, _then_ makes a local > variable. What will happen when the let-binding is dissolved? Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ _______________________________________________ bug-auctex mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-auctex
