Hi Keita,

Ikumi Keita <ikumike...@jcom.home.ne.jp> writes:

> [To developpers]
> Why on earth does tex-mode.el use advice for its own function? The whole
> above piece of code can just be composed up as
> ----------------------------------------------------------------------
> (defvar tex-mode--recursing nil)
> (define-derived-mode tex-mode text-mode "generic-TeX"
>   "...doc string..."
>   ;; The file may have "mode: tex" in the local variable
>   ;; block, in which case we'll be called recursively
>   ;; infinitely.  Inhibit that.
>   (let ((tex-mode--recursing tex-mode--recursing))
>     (if (or delay-mode-hooks tex-mode--recursing)
>         ;; We're called from one of the children already.
>         (tex-common-initialization)
>       (setq tex-mode--recursing t)
>       (tex--guess-mode))))
> ----------------------------------------------------------------------
> without any advice, if I understand correctly.
> I think we should file bug report for tex-mode.el. What do others
> think?

I didn't look closely, but I trust your assessment.  Would you file a
bug report for tex-mode.el with your suggestion above?

Best, Arash

Reply via email to