Update of /cvsroot/audacity/audacity-src/src/export
In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv10410
Modified Files:
ExportMP3.cpp
Log Message:
Prevent referencing freed pointer if beWriteInfoTag() is used while exporting
tags.
Index: ExportMP3.cpp
===================================================================
RCS file: /cvsroot/audacity/audacity-src/src/export/ExportMP3.cpp,v
retrieving revision 1.107
retrieving revision 1.108
diff -u -d -r1.107 -r1.108
--- ExportMP3.cpp 23 Mar 2009 22:20:27 -0000 1.107
+++ ExportMP3.cpp 20 Apr 2009 04:55:50 -0000 1.108
@@ -1292,6 +1292,7 @@
else if (beWriteInfoTag) {
f.Flush();
beWriteInfoTag(mGF, OSOUTPUT(f.GetName()));
+ mGF = NULL;
}
#endif
else if (lame_mp3_tags_fid) {
@@ -1727,6 +1728,9 @@
// Always write the info (Xing/Lame) tag. Until we stop supporting Lame
// versions before 3.98, we must do this after the MP3 file has been
// closed.
+ //
+ // Also, if beWriteInfoTag() is used, mGF will no longer be valid after
+ // this call, so do not use it.
exporter.PutInfoTag(outFile, pos);
// Close the file
------------------------------------------------------------------------------
Stay on top of everything new and different, both inside and
around Java (TM) technology - register by April 22, and save
$200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco.
300 plus technical and hands-on sessions. Register today.
Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________
Audacity-cvs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/audacity-cvs
