Thanks Eric, checked in to 210Cays, HEAD BR Yury
>-----Original Message----- >From: ext Eric Hyche [mailto:ehy...@real.com] >Sent: Tuesday, August 04, 2009 6:48 AM >To: Ramanovich Yury (Nokia-D-MSW/Dallas); >ribosome-...@helixcommunity.org; >datatype-...@helixcommunity.org; audio-dev@helixcommunity.org; >common-...@helixcommunity.org >Subject: RE: [Audio-dev] CR needed: helix Symbian header changes > >Looks good to me. > >======================================= >Eric Hyche (ehy...@real.com) >Principal Engineer >RealNetworks, Inc. > >>-----Original Message----- >>From: audio-dev-boun...@helixcommunity.org >>[mailto:audio-dev-boun...@helixcommunity.org] On Behalf Of >>yury.ramanov...@nokia.com >>Sent: Monday, August 03, 2009 2:32 PM >>To: ribosome-...@helixcommunity.org; datatype-...@helixcommunity.org; >>audio-dev@helixcommunity.org; common-...@helixcommunity.org >>Subject: [Audio-dev] CR needed: helix Symbian header changes >> >>"Nokia submits this code under the terms of a commercial contribution >>agreement with RealNetworks, and I am authorized to >contribute this code under said agreement." >> >>Modified by: yury.ramanov...@nokia.com >> >>Reviewed by: >> >>Date: 08/03/2009 >> >>Project: SymbianMmf_wm >> >>ErrorId: N/A >> >>Synopsis: helix xSymbian header changes >> >>Overview: xSymbian changes include 1) certain symbian headers >>splitting and 2) symbian header export structure change according to >>SW layers >> >>Solution: 1) helix changes due to symbian header splitting are done >>under SYMBIAN_ENABLE_SPLIT_HEADERS flag. Basically, Symbian >created new >>headers for certain internal classes. Currently this flag is not >>enabled in the environment. The testing of this change was >done with this flag enabled. >> >>2) Some xSymbian header files include other headers from >>sub-directories without the sub-dir information in the include >>statement. This forces all clients of the header to add the needed >>sub-dirs to their own system include statements. The goal is to force >>all the clients to use only system include macros according >to their respective SW layer ( like MW_LAYER_SYSTEMINCLUDE ) >from platform_path.hrh, where any macro there always has >/epoc32/include dir. >> >>This change is to remove SYSTEMINCLUDE statements from helix .mmp >>files and from system include path list for non-mmp builds whenever >>possible and add subdirs where needed to include statements >to compensate for that. >>Right now: >>SYSTEMINCLUDE /EPOC32/INCLUDE/mmf >>SYSTEMINCLUDE /EPOC32/INCLUDE/mmf/server Are removed from all .mmp >>files and SYSTEMINCLUDE /EPOC32/INCLUDE/mmf/devvideo are removed from >>mdfvidrender.mmp file >> >>SYSTEMINCLUDE /EPOC32/INCLUDE/libc is left as an exception to >the rule. >>SYSTEMINCLUDE /EPOC32/INCLUDE/mmf/common cannot be removed at present >>because hxmmfbasectrl.h includes CustomInterfaceBuilder.h and >>CustomInterfaceCustomCommandParser.h which are themselves need to be >>modified as part of xSymbian change. Once >CustomInterfaceBuilder.h and >>CustomInterfaceCustomCommandParser.h are corrected their >includes, then helix can remove SYSTEMINCLUDE >/EPOC32/INCLUDE/mmf/common. >> >>The associated .cf files changes are done under >>HELIX_CONFIG_SYMBIAN_HEADER_STRUCTURE_CHANGE flag, which is >only enabled in helix-client-s60-52-common.pfi. >> >> >>Files Added: >>None. >> >>Files Modified: >>/ribosome/build/umakepf/helix-client-s60-52-common.pfi >>/ribosome/build/umakecf/symbian-armv5.cf >>/ribosome/build/umakecf/symbian-emulator-winscw.cf >>/ribosome/build/umakecf/symbian-plat-sec.cf >> >>/audio/device/pub/platform/symbian/CHXAudioOutputConfigUtil.h >>/audio/device/pub/platform/symbian/CHXBaseAudioSession.h >>/audio/device/pub/platform/symbian/CHXBaseDevSoundObserver.h >>/audio/device/pub/platform/symbian/CHXMMFDevSound.h >>/clientapps/symbianMmf/hxmmfplayctrl.h >>/clientapps/symbianMmf/common/hxmmfbasectrl.h >>/common/fileio/platform/symbian/HxMMDataSource.cpp >>/common/fileio/pub/platform/symbian/asynchronousmultireader.h >>/common/fileio/pub/platform/symbian/hxdatasourcemmfclip.h >>/common/netio/pub/platform/symbian/hxsymbiansocket.h >>/datatype/mdf/audio/dsp/mdfaudfmt.h >>/datatype/mdf/audio/dsp/mdfdevsound.h >>/datatype/mdf/video/renderer/umakedll >>/datatype/mdf/video/renderer/umakelib >>/datatype/mdf/video/renderer/mdfdevice/client/CMDFDevVideoClient.h >> >> >>Image Size and Heap Use impact: minor >> >>Module Release testing (STIF) : MRT subset ongoing. >> >>Test case(s) Added : No. >> >>Memory leak check performed : Yes. No new leaks introduced >> >>Platforms and Profiles Build Verified: >helix-client-s60-50-mmf-mdf-dsp, >>helix-client-s60-50-mmf-mdf- arm >> >>Platforms and Profiles Functionality verified: armv5, winscw >> >>Branch: 210CayS, HEAD >> > > _______________________________________________ Audio-dev mailing list Audio-dev@helixcommunity.org http://lists.helixcommunity.org/mailman/listinfo/audio-dev
