Since uint is used in many places inside audio/fixptresampler and
converting it to UINT32 may cause problems on 64-bit platforms.
Therefore checked-in the diff changes in Atlas310 only.
Thanks,
Deepak Jain
On Fri, 2009-08-28 at 06:58 -0700, Gregory Wright wrote:
> +#ifndef _ARM
> typedef unsigned int uint;
> +#endif //_ARM
>
> This kind of code is really messy to have scattered about the code
> base. Can you see if we can just use a datatype we have in hxtypes.h?
>
> uint --> UINT32
>
> or whatever makes sense for that code. You will need to keep in mind
> what happens on 64-bit platforms.
>
> Then we could just remove that line.
>
> If that doesn't work then you change looks OK.
> --greg.
>
>
> On Aug 28, 2009, at 2:42 AM, Deepak Jain wrote:
>
> > Project: Real Player for MID - ARM.
> >
> > Synopsis: Fix for Compilation issue on ARM
> >
> > Overview:
> >
> > During cross compilation for ARM, inside audio/fixptresampler, we
> > usually
> > get this error:
> >
> > In file included from resample.c:51:
> > core.h:43: error: redefinition of typedef 'uint'
> > /usr/include/sys/types.h:153: error: previous declaration of 'uint'
> > was here
> >
> > To fix that, wrapped this inside _ARM define.
> > Find diff below.
> >
> > Files Modified:
> > audio/fixptresampler/core.h
> >
> > Image Size and Heap Use impact (Client -Only):
> > None.
> >
> > Platforms and Profiles Affected:
> > None.
> >
> > Distribution Libraries Affected:
> > None.
> >
> > Distribution library impact and planned action:
> > None.
> >
> > Platforms and Profiles Build Verified:
> > BIF: hxcleint_3_1_0_atlas_restricted
> > Target: player_mid_all_installers
> > Profile: helix-client-moblin
> >
> > Branch:
> > Atlas310
> >
> > Thanks,
> > Deepak Jain
> >
> > Index: core.h
> > ===================================================================
> > RCS file: /cvsroot/audio/fixptresampler/core.h,v
> > retrieving revision 1.2
> > diff -u -r1.2 core.h
> > --- core.h 30 Mar 2007 09:36:45 -0000 1.2
> > +++ core.h 28 Aug 2009 08:31:02 -0000
> > @@ -40,7 +40,9 @@
> > * Internal state.
> > */
> >
> > +#ifndef _ARM
> > typedef unsigned int uint;
> > +#endif //_ARM
> >
> > typedef struct state_t {
> > int up;
> >
> >
> >
> > _______________________________________________
> > Audio-dev mailing list
> > Audio-dev@helixcommunity.org
> > http://lists.helixcommunity.org/mailman/listinfo/audio-dev
>
_______________________________________________
Audio-dev mailing list
Audio-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/audio-dev
