Thanks Eric for the review. Changes checked in to head and brizo
Regards Girish -----Original Message----- From: ext Eric Hyche [mailto:ehy...@real.com] Sent: Thursday, November 12, 2009 8:52 AM To: Rathinasamy Rajesh (Nokia-D/Dallas) Cc: Shetty Girish (Nokia-D/Dallas); nokia-private-...@helixcommunity.org; common-...@helixcommunity.org; audio-dev@helixcommunity.org; client-...@helixcommunity.org Subject: Re: [Audio-dev] Re: [Nokia-private-dev] CR : Symbian Foundation - Replacing backslashes with forward slashes Ok - that's fine. On Nov 12, 2009, at 9:41 AM, rajesh.rathinas...@nokia.com wrote: > Hi Eric, > The warning results are through a code scanner kind of tool which is not > integrated with build profiles and hence the change in win32 part of code. > > Thanks, > Rajesh. > > > -----Original Message----- > From: audio-dev-boun...@helixcommunity.org > [mailto:audio-dev-boun...@helixcommunity.org] On Behalf Of ext Eric > Hyche > Sent: Thursday, November 12, 2009 8:14 AM > To: Shetty Girish (Nokia-D/Dallas) > Cc: nokia-private-...@helixcommunity.org; > common-...@helixcommunity.org; audio-dev@helixcommunity.org; > client-...@helixcommunity.org > Subject: [Audio-dev] Re: [Nokia-private-dev] CR : Symbian Foundation - > Replacing backslashes with forward slashes > > Why do we need the change inside Win32-only code? > > Other than that, looks good. > > Eric > > On Nov 10, 2009, at 4:34 PM, girish.she...@nokia.com wrote: > >> "Nokia submits this code under the terms of a commercial contribution >> agreement with Real Networks, and I am authorized to contribute this code >> under said agreement." >> Modified by: girish.she...@nokia.com >> Reviewed by: >> Date: 11/10/2009 >> Project: phonon_backend >> ErrorId: N/A >> Synopsis: Making Symban Foundation specific changes for replacing >> backward slashes with forward slashes >> Overview: >> For SF, we will have to replace backward slashes used in path by >> forward slashes Files modified: >> /cvsroot/audio/device/test/platform/symbian/greg2/src/Greg2Container. >> c pp,v /cvsroot/client/encodesvc/common/system/pub/hxtthread.h,v >> /cvsroot/common/import/stlport/BC50/limits.h,v >> Files added: None >> Image Size and Heap Use impact: None. >> Module Release testing (STIF) : N/A >> Test case(s) Added : No >> Memory leak check performed : Yes >> Platforms and Profiles Build Verified: helix-client-s60-52-ng >> Platforms and Profiles Functionality verified: armv5, winscw >> Branch: HEAD, BRIZO >> Diff: >> >> <diff.txt>_______________________________________________ >> Nokia-private-dev mailing list >> nokia-private-...@helixcommunity.org >> http://lists.helixcommunity.org/mailman/listinfo/nokia-private-dev > > Eric Hyche (ehy...@real.com) > Principal Engineer > RealNetworks, Inc. > > > > > _______________________________________________ > Audio-dev mailing list > Audio-dev@helixcommunity.org > http://lists.helixcommunity.org/mailman/listinfo/audio-dev Eric Hyche (ehy...@real.com) Principal Engineer RealNetworks, Inc. _______________________________________________ Audio-dev mailing list Audio-dev@helixcommunity.org http://lists.helixcommunity.org/mailman/listinfo/audio-dev
