From: Mateusz Guzik <[email protected]>

1. we already expect the refcount is 1.
2. path creation predicts name == iname

I verified this straightens out the asm, no functional changes.

Signed-off-by: Mateusz Guzik <[email protected]>
Link: https://patch.msgid.link/[email protected]
Reviewed-by: Jan Kara <[email protected]>
Signed-off-by: Christian Brauner <[email protected]>
---
 fs/namei.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index 37beb524b362..bb306177b8a3 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -284,7 +284,7 @@ void putname(struct filename *name)
                return;
 
        refcnt = atomic_read(&name->refcnt);
-       if (refcnt != 1) {
+       if (unlikely(refcnt != 1)) {
                if (WARN_ON_ONCE(!refcnt))
                        return;
 
@@ -292,7 +292,7 @@ void putname(struct filename *name)
                        return;
        }
 
-       if (name->name != name->iname) {
+       if (unlikely(name->name != name->iname)) {
                __putname(name->name);
                kfree(name);
        } else
-- 
2.47.3


Reply via email to