Jeff Mahoney:
> This patch updates aufs to the 2.6.25 API. It uses the new API where
> possible and provides wrappers for the older versions to use.
>
> Most of the changes are focused around the switch in struct nameidata
> from a {mnt,dentry} pair to struct path. This is kind of ugly, since
> it means declaring a struct path for each site.
>
> The read_inode super_operation was also been eliminates, so the inode
> reading code has been updated to follow current kernel conventions.
Thanks.
I don't have major objections, but here are some minor comments.
> --- a/fs/aufs/export.c
> +++ b/fs/aufs/export.c
> @@ -314,13 +314,14 @@ decode_by_path(struct super_block *sb, a
> {
> struct dentry *dentry, *h_parent, *root, *h_root;
> struct super_block *h_sb;
> - char *path, *p;
> + char *pathname, *p;
__putname(path) at the bottom of this function should be changed too.
> --- a/fs/aufs/misc.c
> +++ b/fs/aufs/misc.c
:::
> @@ -127,16 +128,16 @@ struct nameidata *au_fake_dm(struct name
>
> DiMustAnyLock(nd->dentry);
>
> - fake_nd->dentry = NULL;
> - fake_nd->mnt = NULL;
> + nd_path(&fake_nd).dentry = NULL;
> + nd_path(&fake_nd).mnt = NULL;
fake_nd is a pointer so '&' should not be added (several places).
> --- a/fs/aufs/super.h
> +++ b/fs/aufs/super.h
> @@ -30,11 +30,7 @@
> #include <linux/fs.h>
> #include <linux/version.h>
> #include <linux/cramfs_fs.h>
> -#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 19)
> #include <linux/magic.h>
> -#else
> -#include <linux/nfs_fs.h>
> -#endif
> #include <linux/aufs_type.h>
> //#include "hinode.h"
> #include "misc.h"
magic.h doesn't exist in linux-2.6.18 and earlier.
The condition is necessary.
> --- a/fs/aufs/xino.c
> +++ b/fs/aufs/xino.c
:::
> -#ifndef LLONG_MAX /* before linux-2.6.18 */
> -#define LLONG_MAX ((long long)(~0ULL >> 1))
> -#endif
> #define Au_LOFF_MAX ((loff_t)LLONG_MAX)
LLONG_MAX is not defined /* before linux-2.6.18 */.
We need this.
Junjiro Okajima
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
