Am Montag, den 11.08.2008, 16:29 +0200 schrieb Julian Andres Klode: > Am Montag, den 11.08.2008, 16:19 +0200 schrieb Julian Andres Klode: > > Am Montag, den 11.08.2008, 12:06 +0900 schrieb > > [EMAIL PROTECTED]: > > > Julian Andres Klode: > > > > The patches fix some small issues. > > > > > > 08_bashisms.dpatch: > > > Will you explain why 'test' is removed? > > The first change from test BLAH to [ BLAH ] was more or less a mistake. > > > > The other changes like "test X -a Y" to "test X && test Y" are required > > by the Debian Policy, they improve the readability of the code, and they > > don't cause problems for other distributions. > Seems I was a bit wrong. It is actually not required by the policy. But > checkbashisms gives warnings (at least if run with -p). Need to take a > look at it. Now the reason: -a and -o are not POSIX features, but XSI extensions. See http://www.opengroup.org/onlinepubs/009695399/utilities/test.html. > > > > > While posix shell doesn't have an internal test command, /bin/test > > > should be avialble. > > > Also I don't understand why these are necessary > > > > > > -usage: $0 "dir" "command" > > > +usage: $0 "dir" "[command]" > > > ::: > > > +#HOSTNAME=nobashism - set in an external script and is no bashism. > > These are not necessary, and could have been removed from the patch. But > > they also have their reasons: > > > > The 1st change improves the help by using a common "expression" that > > "command" is optional (which is true, because chroot does not need a > > command. > > > > The 2nd one is just a reminder that the variable HOSTNAME is no bashism > > and is set in another file. (In case someone else looks at the code, he > > might think it's a bashism). > > > > > > I will fix about 'local' as you wrote. > > > > > > > > > 09_fixmanpage.dpatch: > > > Are you sure that these hyphens in '.nf' (no format) section should be > > > escaped? > > They were reported by lintian (http://packages.debian.org/lintian), and > > I fixed them. I can see no problems after escaping them. > > > > > > > > > Junjiro R. Okajima > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > > Build the coolest Linux based applications with Moblin SDK & win great > > prizes > > Grand prize is a trip for two to an Open Source event anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
