On Mon, 2014-07-21 at 16:01 +0900, sf...@users.sourceforge.net wrote: > Ian Campbell: > > In file included from /=ABPKGBUILDDIR=BB/include/linux/mm.h:23:0, > > from /=ABPKGBUILDDIR=BB/include/linux/pid_namespace.h:6, > > from /=ABPKGBUILDDIR=BB/include/linux/ptrace.h:9, > > from /=ABPKGBUILDDIR=BB/arch/arm64/include/asm/compat.h:26, > > from /=ABPKGBUILDDIR=BB/arch/arm64/include/asm/stat.h:23, > > from /=ABPKGBUILDDIR=BB/include/linux/stat.h:5, > > from /=ABPKGBUILDDIR=BB/include/linux/module.h:10, > > from /=ABPKGBUILDDIR=BB/init/main.c:15: > > /=ABPKGBUILDDIR=BB/include/linux/fs.h:1575:64: warning: 'struct kstat' decl= > > ared inside parameter list [enabled by default] > > int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *); > > I will definitely merge and release the patch we made, but I want you to > confirm one thing. > If the problem is the declaraion of kstat only, then declaring it in > fs.h will solve the problem too?
I think it might, I'm not sure though. > Or other similar problems will happen? There were some other errors in the original buildd log at http://buildd.debian-ports.org/status/fetch.php?pkg=linux&arch=arm64&ver=3.14.12-1&stamp=1405234443 but they were resolved as part of this patch too so I didn't investigate much further. Some of them were missing prototypes for get_file and file_update_time. The one I'm least sure about is the missing S_IS??? defines. I think most of those would be hard to solve with a fwd declaration without duplicating the complete definition. Cheers, Ian. ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds