Hi J. R.,

Thanks for the quick response!

On Tue, Mar 03, 2015 at 11:56:11PM +0900, sf...@users.sourceforge.net wrote:
> Phil Sutter:
> > This applies to linux-3.12.37 onwards, see commit
> > 4b2f6663ebde6bed50209a05041b34c203116253 for reference.
> 
> The original commit is
>       946e51f 2014-11-03 move d_rcu from overlapping d_child to overlapping 
> d_alias
> in v3.19, and aufs3.19 supports it.
> Also aufs3.18.1+ supports it too since v3.18.1 backported it.
>       4a667ef 2014-12-25 aufs: optimize ac_dcsub_pages() by dcache:d_walk()
>       30d345d 2014-12-30 aufs: for linux-3.19, d_alias and d_child

Yes, exactly. Since I was specifically sending in for aufs3.12.x branch,
I preferred referencing the relevant stable branches' backport commit
ID.

After finding some ML thread about the addressed problem, I checked the
named AuFS branches for possible fixes to cherry-pick, but the code in
question was apparently reworked completely.

> But aufs already stopped supporting 3.12 series, so I won't include your
> patch into aufs releases.
> But there will be other users who will gladly and thankfully adopt it.

Please reconsider this decision, for the following motivation:

- 3.12 is LTS, so is likely to be in productive use in other companies
  as well.

- OverlayFS is only available from 3.18 onwards and AFAICT there is no
  effort in backporting it, which makes AuFS availability more important
  in older versions than newer ones.

- My patch is small and simple (and breaks <v3.12.37, but that's another
  topic ;).

- Only conservative changes are expected in stable branches, maintaining
  it should not cost too many nerves. OK, the change above without
  introducing a macro for compatibility is a perfect counterexample. If
  requested, I would volunteer in maintaining aufs3.12.x compatibility.

Best regards, Phil


-- 
Viprinet Europe GmbH
Gaustr. 22-32
55411 Bingen am Rhein
Germany

Phone/Zentrale:               +49 6721 49030-0
Direct line/Durchwahl:        +49 6721 49030-134
Fax:                          +49 6721 49030-109

phil.sut...@viprinet.com
http://www.viprinet.com

Registered office/Sitz der Gesellschaft: Bingen am Rhein, Germany
Commercial register/Handelsregister: Amtsgericht Mainz HRB44090
CEO/Geschäftsführer: Simon Kissel

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/

Reply via email to