On Sat, 2016-02-20 at 09:14 +0100, Philip Müller wrote: > Hi, > > forget about it. It was my bad. I've something in my create-aufs.sh > patch. Have to remember why I added it ... > > grep -qse 'EXPORT_SYMBOL(' aufs3-standalone.patch && \ > sed -i-old -e 's|EXPORT_SYMBOL(|EXPORT_SYMBOL_GPL(|' aufs3-standalone.patch
I don't know why _you_ added it, but I've always done that same substitution when integrating aufs into the Debian package. My reasoning was that if a function is not already exported, it must be intended as "an internal implementation issue, and not really an interface" which is precisely where EXPORT_SYMBOL_GPL is appropriate <https://www.kernel.org/doc/htmldocs/kernel-hacking/sym-exportsymbols-gpl.html>. Okajima-san, please consider following this practice. Ben. -- Ben Hutchings If God had intended Man to program, we'd have been born with serial I/O ports.
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140