Hi David, Thanks for the comments.
I've squashed the commits into 12 commits which all pass unit tests and added notes in NEWS. See https://github.com/raphink/augeas/compare/dev;inifile_squashed Raphaël On Wed, Feb 6, 2013 at 9:29 PM, David Lutterkort <lut...@redhat.com> wrote: > Hi Raphael, > > On Fri, 2013-01-11 at 00:31 +0100, Raphaël Pinson wrote: > > Last update for the day: > > > > I've made new changes to support other features by default: > > > > * IniFile now supports doseol by default, because there's often > > (sadly) IniFiles can use \r\n as eol. The IniFile-based lenses have > > been fixed accordingly; > > * There are now entry_generic and entry_multiline_generic definitions > > allowing to avoid redefining too much in lenses, when # and ; are > > allowed in values for example. > > > > Again, these changes require a few adaptions in existing IniFile-based > > lenses. The diff in the patch series [1] demonstrates the kind of > > changes that are necessary to make, essentially: > > > > * Excluding \r as well as \n from values because of the doseol > > support; > > * Fixing definitions using deprecated IniFile definitions (such as > > sto_to_eol or sto_to_comment). I could optionally keep these in > > inifile.aug for compatibility purpose, even though they are not used > > anymore; > > Yes, they should stay around, with a deprecation warning in the comment. > > > * Changing { "#comment" } into {} in test files since empty comments > > are mapped as empty nodes; > > * Fixing double quoted values in tests (and code) since smart quotes > > are used. > > > > All these are not huge changes but they do require editing/debugging, > > although I believe the benefits are well worth it (more standard > > lenses, support for smart quotes, simple to use "loose" lenses, doseol > > support). > > All these changes make sense to me; my only comment is that your patch > series needs to be modified a bit: you have to make sure that all the > tests pass after each patch (to preserve bisectability), which means > that you have to combine any change to IniFile with all the fixups > required in lenses. > > We also need to make sure your notes on the changes make it into the > release notes etc. Just add them to the NEWS file already so we won't > forget that. > > David > > > -- Raphaël Pinson Administrateur Systèmes & Réseaux Camptocamp France Savoie Technolac BP 352 48, avenue du Lac du Bourget 73372 Le Bourget du Lac, Cedex www.camptocamp.com
_______________________________________________ augeas-devel mailing list augeas-devel@redhat.com https://www.redhat.com/mailman/listinfo/augeas-devel
