On Sun, Jan 11, 2009 at 9:23 AM, Gergely Imreh <[email protected]> wrote: > 2009/1/11 Dan McGee <[email protected]>: >> On Sat, Jan 10, 2009 at 9:45 PM, Gergely Imreh <[email protected]> wrote: >>> Hi, >>> >>> Attached is a proposed fix to AUR bug #12698. >>> I tested it with the official kernel26 PKGBUILD (among others) that >>> would show this bug in the current version. >> >> This could still fail on the corner case where the '#' sign is located >> inside a quoted block of text, e.g.: >> echo "## finished building ##" >> >> I don't think URLs can ever contain a '#' sign though, so we are good there. >> >> -Dan >> > > Would it? The new code only replaces # within when making the > variablename=( ) blocks into a single line. It wouldn't touch anything > within build(), I think.... > If the URL would contain #, then makepkg would fail just the same.
Ignore me here, looks like you are right. :) /me decides to go drink his Sunday morning coffee before saying more stupid things -Dan
