On Fri, Oct 21, 2011 at 03:29:28PM -0500, Dan McGee wrote: > On Thu, Oct 20, 2011 at 10:17 AM, Lukas Fleischer > <[email protected]> wrote: > > On Thu, Oct 20, 2011 at 09:32:13AM -0500, Dan McGee wrote: > >> On Mon, Aug 22, 2011 at 7:18 PM, Dan McGee <[email protected]> wrote: > >> > Replacing with CSS styles where appropriate. A previously unused CSS > >> > style is tweaked in the stylesheet to match most of what was done via > >> > non-CSS styling. > >> > > >> > Signed-off-by: Dan McGee <[email protected]> > >> > --- > >> > > >> > Things look mostly the same on all these pages. However, there are a few > >> > exceptions- for example, the removal of the needless centering of the > >> > account > >> > search form. > >> Ping on this, and all the other patches from this day? Lukas, you had > >> them on your WIP branch, but then they all disappeared... > > > > I'm still waiting for that patch set (patch 5, actually) to be > > resubmitted. If you're too busy, just let me know and I'll look into > > that. I just thought I'd wait since you sent me a mail saying that you > > will fix and resend that patch later. > > We work differently. :) > > Usually if patches that don't have dependencies on each other look > good, I tend to merge them and not wait for the whole set to be > resubmitted. In this case, since it was 1/6, it shouldn't have any > dependencies. Given that I got no feedback on either the utf8 one or > this one, I either assume 1) you didn't originally see it or 2) you > forgot to merge it.
Agreed, yeah. We should only hold pack patches if they might be affected by refactoring/resubmissions. I guess that it was a conjunction of the fact that I was really busy when you submitted the patches for the first time (exam time :) ) and the fact that you told me you will fix the outstanding issues when you get round to it that put me into some kind of an "idle mode" :) I'll have a look at your patches as soon as possible! > > I'll be happy to fill people's inboxes with an identical patch 2 > months later, but I don't want to waste time when people review it and > wonder what has changed, that's all. I'm all for adding small comments to resubmitted patches, unless their changelog is obvious if you follow the discussion on the mailing list :) > > -Dan
