On Tue, Jul 17, 2012 at 5:02 PM, Lukas Fleischer <[email protected]> wrote: > On Tue, Jul 17, 2012 at 03:37:32PM -0400, [email protected] wrote: >> On Sun, Jul 15, 2012 at 5:23 PM, Lukas Fleischer >> <[email protected]> wrote: >> > This implements nicer looking URLs, such as "/packages/" instead of >> > "/packages.php", "/packages/$pkgname/" instead of "/packages.php?ID=$id" >> > etc. >> > >> > Note that these patches are not ready to be merged yet but I'd like to >> > get some comments. We'd probably also have to add rewrite rules to our >> > AUR setup on sigurd or add legacy rules to the routing back end to >> > ensure old URLs still work. >> > >> >> I didn't realize you were already merging these. Setting >> $USE_VIRTUAL_URLS = false seems broken on my test setup. I'm getting a >> call to an undefined function error on any page besides index.php. I'm >> guessing that the include_once("routing.inc.php") should really be in >> aur.inc.php not in index.php? > > Yeah, you're probably right. The include() should be moved. > >> >> It also seems that all CSS doesn't load properly. I'm guessing this is >> related to the change to absolute URI paths for stylesheets? > > Works for me... Did you clear the browser cache? Does it work if you > enable "$USE_VIRTUAL_URLS"? >
Clearing cache doesn't work. Enabling/disabling $USE_VIRTUAL_URLS makes no difference. I think I know what the problem is though. Commit a03c684ecd51327f9c6921a6e0001d82e3223799 describes using absolute URI paths for CSS and images. They are actually root-relative with that commit, not absolute. So someone like me with a strange http root doesn't get the CSS loaded properly. It could be fixed by putting $AUR_LOCATION before any CSS or image paths (thus using truly absolute paths). Another solution was also previously suggested by Ike in regards to portability: http://mailman.archlinux.org/pipermail/aur-dev/2012-July/002041.html >> >> Sorry I don't have much time to fully review these but this is what >> I've seen so far. > > Don't worry -- I discovered a lot of other minor regressions that were > probably introduced when merging all the archweb and virtual path > stuff... Lots of bug fixes to follow. > Regards, Jason
