On 6/2/08, Loui <[EMAIL PROTECTED]> wrote: > On Mon, 2 Jun 2008 07:19:40 +0200 > "Ronald van Haren" <[EMAIL PROTECTED]> wrote: > >> Although as you stated contributing packages is not your primary goal, >> I suggest you still take another look at your PKGBUILDs and correct >> the small mistakes that are still in there. If you need help finding >> them please let me know and I'm happy to point them out. > > I'll have a look at those three I still maintain, but I'd be glad to > receive pointers as well. > from a quick look:
tomatoes: - try to avoid custom variables (_pkgdata). It is not needed and it only appears once. - license is an array - you can use install -Dm755 to install the executable instead of mkdir -p and install (not that what you did is wrong, it's just easier) brlcad: - You can use 'install -Dm' as above for future reference, you can use $srcdir and $pkgdir instead of $startdir/src and $startdir/pkg (of course both work equally well so you can use whatever you like)
