On Tue, Oct 5, 2010 at 2:01 AM, Magnus Therning <[email protected]> wrote:
> On 05/10/10 07:50, Daniel J Griffiths (Ghost1227) wrote: > > don't think i'd even do that, but just to nitpick, it'd be better written > > as: > > > > [[ -f /usr/bin/gtk-config ]] && COPTS="--with-gtk" > > > > then add $COPTS to your compile line. > > I think you should also make sure that gtk then becomes a dependency of the > resulting package to prevent accidental removal of gtk. > > You also need to consider that doing this means that users would see > different > behaviour from what they believe is the same package. It could be > confusing, > and possibly complicate support and dealing with bugs. > > Personally I think it's a horrible idea to inspect the environment and make > use of stuff that happens to be there. I don't like it when it's done in > Makefiles and I think it's an even worse idea to do it in PKGBUILDs. > That's > just my opinion though. > > /M > > -- > Magnus Therning (OpenPGP: 0xAB4DFBA4) > magnus＠therning．org Jabber: magnus＠therning．org > http://therning.org/magnus identi.ca|twitter: magthe > > Ok thanks for your input, I probably won't do it, though I wondered for future reference.
