On 11/22/2010 08:02 PM, Eric Bélanger wrote:
On Mon, Nov 22, 2010 at 8:30 PM, Evangelos Foutras<[email protected]>  wrote:
On Tue, Nov 23, 2010 at 3:03 AM, Tony<[email protected]>  wrote:
PKGBUILD: http://archlinux.pastebin.com/B3fyYkrp
It appears that you're using the PKGBUILD as a script that installs
and configures oh-my-zsh for the current user. No files are copied
into the actual package directory ($pkgdir), so you end up with an
empty package. As you understand, this is incorrect behavior. Also
note that while a package is being built, it should never create or
modify files inside the user's home directory (or anywhere outside of
$startdir for that matter).

install file: http://archlinux.pastebin.com/1HpZXGwF
I'd lose the ASCII art and the "oh-my-zsh is now installed" line, for
the sake of keeping the pacman log as clean as possible. In addition,
the "chsh -s /usr/bin/env zsh" line is incorrect; zsh is interpreted
as a separate argument.

And the:
op=$1
shift
$op $*
  are no longer needed.
The new PKGBUILD & install file are much better now. The package is no longer empty. I was a bit stumped on getting oh-my-zsh installed correctly because I was originally under the impression that I needed to /make &&/ /make DESTDIR=$pkgdir install /in order to not have an empty package. However, per the install docs on the main repository <https://github.com/robbyrussell/oh-my-zsh> page, we only need to ensure the "/oh-my-zsh"/ directory be hidden in the user's $HOME.

From the oh-my-zsh repository: /"*NOTE*: If you already have a ~/.zshrc file, you should back it up. |cp ~/.zshrc ~/.zshrc.orig| in case you want to go back to your original settings. /|/cp ~/.oh-my-zsh/templates/zshrc.zsh-template ~/.zshrc". /

|PKGBUILD: http://archlinux.pastebin.com/n5B7tALf
.install: http://archlinux.pastebin.com/pwfaLbM0

Thanks for the very helpful input Evangelos & Eric!

--
Tony

Reply via email to