On Fri, Feb 4, 2011 at 09:37, Dave Reisner <[email protected]> wrote: > On Fri, Feb 04, 2011 at 09:07:07AM -0500, Adam Weiss wrote: >> Hey all, >> I've been lurking for quite a while and recently decided to take the >> plunge and maintain a couple packages. >> >> Please give me some feedback on them since I probably missed some things: >> http://aur.archlinux.org/packages.php?ID=34191 >> http://aur.archlinux.org/packages.php?ID=45976 >> >> Also, this is the first time I've tried posting from Gmail, so let me >> know if something looks funny. >> >> Thanks, >> -Adam > > > in openscenegraph-svn: >> if [ $_downloadsampledata == 'True' ] ; then > > this is invalid syntax, as == is not a valid operator for [. makepkg > uses bash, so please use the keyword [[ instead of the builtin [. > > I disagree with your decision to do checkouts in the package() function. > Do this in the build function instead. package() should do strictly > that. package. > > Neither of these packages arch of arch 'any'. 'any' means that nothing > is compiled, as is usually the case with an interpreted language like > perl or python. Both these packages compile code, and so they are > architecture specific. Please specify this as arch=('i686' 'x86_64'). > > optdepends are malformed in both PKGBUILDs. Please follow the format > of 'depend: description' stated in PKGBUILD(5). > > Your usage of _exampledir in both PKGBUILDs is a little strange -- hard > code the directory path. It's not likely going to change, and it makes > the process a little more readable. > > dave >
Thanks for the advice Dave, I'll make these changes tonight. -Adam
