On 16 June 2012 14:19, Kwpolska <kwpol...@gmail.com> wrote: > On Sat, Jun 16, 2012 at 1:48 PM, Mateusz Loskot <mate...@loskot.net> wrote: >> On 16 June 2012 07:56, Kwpolska <kwpol...@gmail.com> wrote: >>> >>> * ${srcdir}, ${pkgdir} >> >> I'm not sure I understand. >> Should I remove all uses of these variables? >> I assumed they're set implicitly when user runs makepkg -s > > Nope. In your code, you use $srcdir. When you should use ${srcdir}. > See the difference?
Yes, I do understand the difference, but in your response it wasn't obvious what you are pointing at from. FYI, I copied PKGBUILD from /usr/share/pacman/PKGBUILD-svn.proto installed from https://projects.archlinux.org/abs.git/tree/prototypes/PKGBUILD-svn.proto?id=bd5be0e65bda00d1abe3d0db5cda149b3ee5ba2a >>> and you didn't show us any >>> COPYING, but you install one. >> >> COPYING file is grabbed with sources from SVN. >> Here it is >> http://svn.osgeo.org/metacrs/proj/trunk/proj/COPYING >> Should I include copy of this file in the package? > > Didn't actually check that in the source. If your package does create > a license file in /usr/share/licenses, the current method is okay. If > not, fix it. Understood. Best regards, -- Mateusz Loskot, http://mateusz.loskot.net