Sean Fennell <eadrom> wrote: >> - If the GTK2 and GTK3 versions are built from the same source, then a >> split GTK2/GTK3 package is the way to go. Having separate PKGBUILDs for >> each version just doubles the maintenance work for no good reason (every >> fix and update would need to be applied twice). >> - You should remove the install files that run commands already handled >> by hooks. See https://www.archlinux.org/todo/hooks-part-1/ > > I've done my first pass at updating the packages to use hooks. [1] > > From what andreyv from #aur-general IRC told me, I just need to add the > package that provides the hook to the PKGBUILD's depends() array to set > the hooks needed. The documentation is kinda sparse on the process, at > least what I could find. If anyone has some detailed documentation on > how to update from .install to pacman 5.0 hooks or hooks in general, I > would love to read it so I can better understand what's going on. I > found Allan's blog and an Andrew's github with examples, but that was > pretty much it. Mayhaps my Google-fu was not strong enough. >
Packages such as desktop-file-utils, shared-mime-info or glib2 don't need to be explicitely added as dependencies since gtk already depends on them. Namcap should warn you about this. Other than that, LGTM.
