Hi there,I've been talking to Christian off-list and nobody yet seemed to have posted packaging feedback so I somehow squeezed in a bit of time and gave him a couple of packaging feedback lately. Just for transparency find that list here as well:
mdt-git- should use a better pkgver like the ones from the git packaging guidelines in the wiki which includes actual version numbers - needs some depends that the script is using, you should quickly look at it. f.e. findutils grep awk
pawxel- you need to declare all submodule sources in the sources array, or they always get cloned freshly. take a look how "mono" does it, also note the submodule update command etc
- $pkgdir needs quotes prometheus-mosquitto-exporter- you may also want to specify something like -X main.Version=${pkgver} so the binary reports the correct thing - prometheus-mosquitto-exporter.service a good start for hardening, but maybe you can borrow some more options depending on what it needs to access. things that come to my mind to look up what kind of hardening is available in the service is umurmur, caddy, tor, postgresql
prometheus-mosquitto-exporter-git - better pkgver which reflects the version - same as prometheus-mosquitto-exporter molly-guard - you should pull from a https source - has some unquoted $pkgdir- printing messages in the install file on every upgrade does not sound right
google-chrome-beta: google-chrome-dev- printing messages in the install file on every upgrade does not sound right
mdt:- same as mdt-git: needs some depends that the script is using, you should quickly look at it. f.e. findutils grep awk
kopia: - we have tests, lets use them Good luck, Cheers, Levente
OpenPGP_signature
Description: OpenPGP digital signature
