On 10/22/25 12:07 PM, Lex Black wrote:
Am 22.10.25 um 15:16 schrieb David C Rankin:
AUR Wizards,
With upstream's removal of libboost_system I needed to remove the
Scons config making use of the library. Instead of patching the files,
I simply used a couple of sed expressions to handle the issue from the
PKGBUILD (there were many others there when I stepped in as the
maintainer)
I want to know if it matters, and whether patches are preferred, or
if handling a couple of removals via sed or awk is okay.
I added the following to handle the changes:
# delete libboost_system references from scons due to removal
# from boost/boost-libs upstream in ver. 1.89.
sed -i '/^boostLibs =/s/, "system"//' SConstruct
sed -i '348d' src/third_party/SConscript
Builds fine, only complaint is it has to serial link instead of
using the requested lto link, which I see with some other packages as
well. Anyway, if there is a preference to patch instead of use sed, I
can clean that up on the next commit, but I am curious if there is a
preference or if either/or is okay.
Hi,
If I recall it correctly I have both ways in action :D It boils mostly
down to personal preference? One disadvantage of sed is that it silently
breaks whereas a patch in need of updating will stop the process at the
beginning.
For the packages in the repos they tend to prefer patches over sed calls
so a build stops early if there are issues.
Best regards
Yes, thank you, I'll redo the Scons updates as patches. or at least get
rid of the fragile line-number deletion replacing it with a pattern
matching regex.
That did stand out as being something that would brake with future
modifications to the scons files that altered line-numbering.
Patch it is. Will wait for the next update rather than doing a special
update to change sed to patch -- nothing will break in the interim.
Thank you for your thoughts and feedback!
--
David C. Rankin, J.D.,P.E.
