Hello,
as one of the maintainers of Heroic & its official AUR package
(heroic-games-launcher-bin):
From a quick glance at the PKGBUILD, this seems to be fine. The
weird-looking things they do with overrides is a roundabout way of
re-adding changes from our pnpm-workspace.yaml file (see
https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/4737fdb3db0bbb3c9877335b5fbe376cf0d82427/pnpm-workspace.yaml#L7).
A better way would be parsing those options out of the file (instead of
duplicating them in the PKGBUILD), but I don't know if that's easily
doable with Bun.
I would however question whether this package violates the "Make sure
the package you want to upload is useful" rule. Sure, using Bun instead
of pnpm is a fine personal preference, but do that many people really care?
I guess this opens a more broad question: If an application uses build
system A and has an AUR package, would an alternative package porting it
to build system B be allowed/helpful (assuming both build systems are
reasonably popular)?
One more point is that -bun and -bin are, of course, one letter apart,
and with u & i being right next to one another on the keyboard, this may
be an easy typo to make. There are already too many
"heroic-games-launcher-X" packages on the AUR for our liking, so I'm not
really much of a fan of that (even if it is a coincidence here).
Regards,
Katharina
Am 06.11.26 um 13:22 schrieb mpan:
Hi i was checking if heroic got to main repo recently and have stun
on this
Package Details: heroic-games-launcher-bun 2.22.4-1 (…)
Hello,
Without even checking what the PKGBUILD does, it breaks the
submission guidelines in two ways: (…)
I was too quick to answer and indeed I should have checked the
PKGBUILD contents. :( Apologies to doublemiu, AUR operators, and School.
It’s not a binary distribution. It’s a version of
heroic-games-launcher (without “-bin” or “-bun”), which uses a
different package manager (`bun` instead of `pnmp`).
I have no opinion on why the author would do this, and a quick check
doesn’t suggest to me any malicious attempts. However, there are some
suspicious things. It would require an explanation why they insist on
using an ancient version ot ts-morph (2022, the current one is 28.0.0).
Once more sorry for the mistake, have a nice day.
