Guillaume,
Thanks for the response. I'm happy to provide patches, but to be honest
I'm also still pretty frustrated.
I provided a whole bunch of patches on your font tooling related
packages over a year ago and only bits and pieces of them were applied.
Many of the packages you later bumped without addressing the issues in
my patches. Yes, there were some cosmetic changes (in many cases just
matching the style in your other packages), but the things I *commented
on* along with the patches were important issues reliable URLs,
splitting build() steps from package(), fixing tests that wouldn't run,
removing circular dependencies, etc. Some of these issues I submitted
patches for are still outstanding over a year later.
I'm attaching a refreshed patch to fix this particular package again. In
case the list mangles or drops it you are also copied directly and I'll
comment on the package with a fresh patch.
After you look it over and check the wiki guidelines for Python packages
and confirm that what I'm doing makes sense, please do reconsider adding
me as a co-maintainer to your font tooling packages.
Regards,
Caleb
On 2021-07-17 13:33, Guillaume Horel wrote:
Thanks for your concerns. Maybe you can submit a patch that fixes the
aforementioned issues, or better file a bug with upstream to improve
their test suite. The only patch that you sent made a bunch of cosmetic
changes and changed the download url, but as far as I can see didn't
fix any of the above.
On Sat, Jul 17, 2021 at 11:27 AM <[email protected]> wrote:
alerque [1] filed an orphan request for python-ufo2ft [2]:
Besides OOD, this package has had long running issues with a check()
function that does not run properly because of upstream issues: it
uses an environment better suited to upstream regression testing and
doesn't actually check against the Arch system libraries, while *also*
mistakenly using arch system locale for the suite which blocks builds
in clean chroots. I've reported this several times for more than a
year and it still isn't fixed. I'd like to either maintain or at least
co-maintain this to get clean chroot builds working.
[1] https://aur.archlinux.org/account/alerque/
[2] https://aur.archlinux.org/pkgbase/python-ufo2ft/
From ea176c78a5d842f3f1345888b2a9497f854a4e77 Mon Sep 17 00:00:00 2001
From: Caleb Maclennan <[email protected]>
Date: Thu, 26 Mar 2020 11:21:57 +0300
Subject: [PATCH] Bump, fix build issues, follow Python packaging guidelines
For rational behind some of these, please see:
https://wiki.archlinux.org/title/Python_package_guidelines
* Bump to current version
* Use stable download URL
* Split build() and package()
* Use correct test runner (legacy one breaks based on host env)
* Fix makedepeds (uses SCM setuptools)
* Fix checkdepends (wrong test runner, needs optdepends)
* Match more Arch guidelines such as quoting suggestions
Signed-off-by: Caleb Maclennan <[email protected]>
---
.SRCINFO | 13 +++++++------
PKGBUILD | 32 +++++++++++++++++++-------------
2 files changed, 26 insertions(+), 19 deletions(-)
diff --git a/.SRCINFO b/.SRCINFO
index c084ef0..2c99896 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,20 +1,21 @@
pkgbase = python-ufo2ft
- pkgdesc = A bridge from UFOs to FontTools objects.
- pkgver = 2.21.0
+ pkgdesc = A bridge from UFOs to FontTools objects
+ pkgver = 2.23.0
pkgrel = 1
url = https://github.com/googlefonts/ufo2ft
arch = any
license = MIT
- checkdepends = python-pytest
+ checkdepends = python-compreffor
+ checkdepends = python-pytest-runner
checkdepends = python-skia-pathops
- makedepends = python-setuptools
+ makedepends = python-setuptools-scm
depends = python-booleanoperations
depends = python-cffsubr
depends = python-cu2qu
depends = python-defcon
depends = python-fonttools>=4.21.1
optdepends = python-compreffor
- source = https://pypi.org/packages/source/u/ufo2ft/ufo2ft-2.21.0.zip
- sha256sums = 8387241b9a36ed906a0b99afc80d58cee72ea5266ec0016f17456f765be73300
+ source = https://files.pythonhosted.org/packages/source/u/ufo2ft/ufo2ft-2.23.0.zip
+ sha256sums = 02ceb5201f08b632b84046ddfd11233eaf3633437ccac9981ebf2d944d75616b
pkgname = python-ufo2ft
diff --git a/PKGBUILD b/PKGBUILD
index a04894a..1bb369c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,27 +1,33 @@
# Maintainer: Guillaume Horel <[email protected]>
+# Contributor: Caleb Maclennan <[email protected]>
-pkgname='python-ufo2ft'
-_pkgname='ufo2ft'
-pkgver='2.21.0'
+pkgname=python-ufo2ft
+_pkgname=ufo2ft
+pkgver=2.23.0
pkgrel=1
-pkgdesc="A bridge from UFOs to FontTools objects."
+pkgdesc="A bridge from UFOs to FontTools objects"
url="https://github.com/googlefonts/ufo2ft";
-checkdepends=('python-pytest' 'python-skia-pathops')
+checkdepends=('python-compreffor' 'python-pytest-runner' 'python-skia-pathops')
depends=('python-booleanoperations' 'python-cffsubr' 'python-cu2qu' 'python-defcon' 'python-fonttools>=4.21.1')
-makedepends=('python-setuptools')
+makedepends=('python-setuptools-scm')
optdepends=('python-compreffor')
license=('MIT')
arch=('any')
-source=("https://pypi.org/packages/source/${_pkgname:0:1}/$_pkgname/$_pkgname-$pkgver.zip";)
-sha256sums=('8387241b9a36ed906a0b99afc80d58cee72ea5266ec0016f17456f765be73300')
+source=("https://files.pythonhosted.org/packages/source/${_pkgname::1}/$_pkgname/$_pkgname-$pkgver.zip";)
+sha256sums=('02ceb5201f08b632b84046ddfd11233eaf3633437ccac9981ebf2d944d75616b')
-package() {
- cd "${_pkgname}-${pkgver}"
- python setup.py install --root="${pkgdir}" --optimize=1
- install -D -m644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
+build() {
+ cd "$_pkgname-$pkgver"
+ python setup.py build
}
check() {
cd "$_pkgname-$pkgver"
- python setup.py test
+ python setup.py pytest
+}
+
+package() {
+ cd "$_pkgname-$pkgver"
+ python setup.py install --root="$pkgdir" --optimize=1 --skip-build
+ install -Dm644 -t "$pkgdir/usr/share/licenses/$pkgname/" LICENSE
}
--
2.32.0
