Hi, I think it's fine to do this kind of merge.
However, I have a recommendation to consider beforehand. Though modsecurity is both a library and has an executable, Arch repo maintainers chose the name 'libmodsecurity' for the [extra] repo package. The latter still carries the 'modsec-rules-check' executable. So for a git VCS package on AUR, I think it is the best practice and the most helpful (and least confusing) for users to name that package in alignment with the repo package, i.e: 'libmodsecurity-git' (With provides='libmodsecurity' and conflicts='libmodsecurity'). Cheers, Marcell (MarsSeed) On 5 December 2023 14:41:14 GMT+01:00, [email protected] wrote: >marcool04 [1] filed a request to merge modsecurity [2] into >modsecurity-git [3]: > >The `modsecurity` v3.x.x branch is packaged as `libmodsecurity` in >extra [1]. This does differ from `modsecurity` v2.x.x, which I provide >a PKGBUILD for as `modsecurity2` in the AUR [2]. There is now no need >for this `modsecurity` PKGBUILD, however a `modsecurity-git` PKGBUILD >could be useful for those who wish to stay up to date with the latest >commits on the v3 branch. I have created that `modsecurity-git` >PKGBUILD and feel it would make sense to merge this package into the >`-git` one, but if you feel it is better to delete `modsecurity` from >AUR, then that is fine by me also. I have already pushed `modsecurity` >git history to `modsecurity-git`. > >Regards, >Mark. > >[1] https://archlinux.org/packages/extra/x86_64/libmodsecurity/ >[2] https://aur.archlinux.org/packages/modsecurity2 > >[1] https://aur.archlinux.org/account/marcool04/ >[2] https://aur.archlinux.org/pkgbase/modsecurity/ >[3] https://aur.archlinux.org/pkgbase/modsecurity-git/
