>>> "Paul" == Paul Eggert <[EMAIL PROTECTED]> writes:

 Paul> Stepan Kasal <[EMAIL PROTECTED]> writes:
 >> Paul, can I commit this patch?

 Paul> I like the idea, 

I don't, for several reasons:

1) If I change the value of ACLOCAL_AMFLAGS in my Makefile.am
   and run autoreconf immediately afterwards, this causes
   autoreconf to use the old value that is still in Makefile.
   This sounds bogus.

2) Since we are trying to get people to replace their autogen.sh
   script by autoreconf, I find it inappropriate that autoreconf
   behave differently whether a package has already been
   configured or not.

3) autopoint and libtoolize, i.e., the tools autoreconf runs,
   look at ACLOCAL_AMFLAGS in Makefile.am.  If that does not match
   what you have in Makefile, autoreconf will be difficult to use.

4) I couldn't find a reason why one want to AC_SUBST([ACLOCAL_AMFLAGS])

5) The rationale for or explanation of a block of code should be
   in front of that block of code, not in the ChangeLog.
-- 
Alexandre Duret-Lutz



Reply via email to