Hello,
On Sat, Aug 13, 2005 at 12:00:13AM +0200, Ralf Wildenhues wrote:
> Other way round. I tried to make you do the work for me and did not
> succeed at first. :)
thank you very much. You did most of the work, so I won.
I'll look at the patch soon.
But two comments now, in a hurry:
>
> Hmm. But this:
> | AC_CONFIG_COMMANDS_PRE([dnl
> | m4_ifndef([AH_HEADER], [AC_CONFIG_HEADERS([config.h])])
> | AC_SUBST([CONFIG_H], ["AH_HEADER"])
> | ])
>
> would not be correct, right?
I don't see any problem. It should work. I think that AC_CONFIG_COMMANDS_PRE
is the last opportunity to call AC_SUBST and AC_CONFIG_FOOS.
But it is not documented, yet.
> Quoting 'info Autoconf Configuration\ Headers:
> | The `AC_CONFIG_HEADERS' macro selects this kind of output. It should
> | be called right after `AC_INIT'.
This doesn't seem correct. As far as Autoconf is concerned, AC_CONFIG_HEADERS
might be called just before AC_OUTPUT.
OTOH, it's a good custom to call it at the top.
Perhaps some package could test for AH_HEADER...
Are you willing to prepare another patch and do these two doc enhancements?
Have a nice weekend,
Stepan
