* Eric Blake wrote on Fri, Apr 07, 2006 at 02:46:22PM CEST: > > This patch allows: > ./testsuite -d -k 'C keywords' CFLAGS='-Wall -Werror' > to succeed with gcc 3.4.4. There were so many tests in AC_C_CONST, some > with duplicate names but different scopes, that I relettered the local > variables.
Eric, please make my life easier and resubmit a *minimal* patch that allows me to quickly see what's going on. No renaming. Let's put this in a bit stronger words: until the alpha release, I will reject any non-minimal patch for new stuff, even bugfixes. I don't have unlimited time, and I don't want this release to take unlimited time, and after 2.60 there'll be enough time for everyone to do cleanup patches and thus introduce new bugs. Thanks, Ralf > 2006-04-07 Eric Blake <[EMAIL PROTECTED]> > > * lib/autoconf/c.m4 (AC_C_CONST, AC_C_VOLATILE): Avoid warnings > from gcc.
