On Sun, Apr 09, 2006 at 05:09:59PM +0200, Stepan Kasal wrote: > * tests/mktests: Only touch the products if they would change. > * tests/Makefile.am: Do not call the autom4te for $(TESTSUTE) > directly, use a new rule for $(TESTSUTE).tmp. Move these rules > from the ``maintainer section'' up. Do not distribute > $(TESTSUITE_GENERATED_AT). > (MAINTAINERCLEANFILES): Remove.
As you noted, my accusation that this causes unnecessary `mktests.sh' runs was invalid. Sorry for that. Most of this patch has nothing to do with the original goal of avoiding some spurious `testsuite' rebuilds, but I suppose the other changes are worthwhile. They do expose folks who simply want to run the test suite of an unmodified Autoconf to any portability problems in `mktests.sh'. > --- tests/Makefile.am 9 Apr 2006 11:36:08 -0000 1.100 > +++ tests/Makefile.am 9 Apr 2006 14:01:41 -0000 > -DISTCLEANFILES = atconfig atlocal $(TESTSUITE) > -MAINTAINERCLEANFILES = Makefile.in > +DISTCLEANFILES = atconfig atlocal $(TESTSUITE) $(TESTSUITE_GENERATED_AT) While you're changing it, $(TESTSUITE) and $(TESTSUITE_GENERATED_AT) belong in MOSTLYCLEANFILES, not DISTCLEANFILES. > +$(TESTSUITE): $(TESTSUITE_dependencies) $(AUTOCONF_FILES) > + $(srcdir)/mktests.sh $(AUTOCONF_FILES) > + mv $@ [EMAIL PROTECTED] This needs to be `if test -f $@; then mv $@ [EMAIL PROTECTED]; fi' or similar, for when $(TESTSUITE) does not exist. > + $(MAKE) $(AM_MAKEFLAGS) [EMAIL PROTECTED] > + touch [EMAIL PROTECTED] > mv [EMAIL PROTECTED] $@ > --- tests/mktests.sh 8 Apr 2006 21:44:13 -0000 1.53 > +++ tests/mktests.sh 9 Apr 2006 14:01:41 -0000 > + diff ac$base.at ac$base.tat || : This line was a debugging aid; delete it.
