Paul Eggert <[EMAIL PROTECTED]> wrote:

> Jim Meyering <[EMAIL PROTECTED]> writes:
>
>> Is the concern that "|" might be used as a path separator?
>> Does any shell use that?
>
> The concern was that someone might put "|" in a directory name, and
> that the directory might appear in a PATH.  That patch was part of a
> more-general "support as many characters as possible in file names"
> drive that I was doing at the time.  It was easy to support "|" in
> file names there, so the patch did it.

>> Initially I also changed
>>
>>     $ grep '\<sed ['\''"]s[^/|]' lib/autotest/general.m4
>>     AUTOTEST_PATH=`AS_ECHO(["$AUTOTEST_PATH"]) | sed "s&:&$PATH_SEPARATOR&g"`

Since this AUTOTEST_PATH / PATH_SEPARATOR sed transformation works with
arbitrary values for $AUTOTEST_PATH, I'm changing the & to | there, too.

> I didn't see any problems in your patch; thanks.

Thanks for the review!


Reply via email to