Re: another m4sugar speedup

[Benoit SIGOURE]

On Oct 3, 2007, at 11:59 PM, Eric Blake wrote:

Paul Eggert <eggert <at> CS.UCLA.EDU> writes:

Thanks for these optimizations!  I installed the following minor

"autoconf -f" in coreutils.

further improvement, which on my host yielded a 3% further speedup for

Minor nit for future patches:


summary line (plus one more newline) in my git commit.




1a128bd6e62856ce29d98848a6d424d9f4f9715e Whitespace cleanup.

7b96e241f7c2eeae31b69ef6d64c20943ad2f599 Comment touchups.

git-log _really_ wants a one-line description of the patch, separated by a blank line, before the rest of the commit description. That's why I've been starting to add a summary line to all my ChangeLog entries, then reusing that For an example, this is 'git-log -4 --pretty=oneline' after my latest push: 987a33376699a92cb00962aedd4632d05bc7cef6 Another round of regex avoidance. 9174b63f95aaf58680bda01f1746dc6f44860a59 * lib/m4sugar/m4sugar.m4 (m4_shift2, m4_shift3): New macros. (m4_shiftn): Remove no-longer-needed optimization. Perhaps we should remove m4_shiftn entirely? (m4_case, b4_bmatch, m4_map_sep, m4_bpatsubsts, m4_join): Prefer m4_shift2 and m4_shift3 to m4_shiftn. * lib/autoconf/lang.m4 (_AC_LANG_DISPATCH): Likewise. * lib/m4sugar/ m4sh.m4 (AS_CASE, AS_IF): Likewise. * tests/autotest.at (AT_CHECK_AT_TEST): Likewise.

--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory

Yes, this started as a mere convention but ended up being a rule. The original rationale was that the various tools need to be able to sum up a commit in a single sentence (for example, to find a suitable subject for sending patches by email, to describe a commit in git shortlog, to show a commit in one of the various Git GUI). Now it's more of a rule because if you choose not to do that, you end up with weird behaviors with various Git tools. I complained at some point because git-rebase was even *rewriting* commit messages (how did it dare?! the entire formatting was lost and the commit message put on a single line, just like your example above). This has been fixed several weeks ago though.

PGP.sig
Description: This is a digitally signed message part