-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Ralf Wildenhues on 12/4/2007 2:45 PM: > +AT_SETUP([autom4te and whitespace in file names]) > + > +file='>file with funny \ '\'' \'\'' $ & #!*? name' > +dir='>dir with funny \ '\'' \'\'' $ & #!*? name'
I'm wondering if it is worth splitting this one test into two, in order to get more coverage on Windows ports - one that tests file names that can be created by default on any windows platform, and one that covers the remaining characters that can only be created in a cygwin managed mount. In other words, ', $, &, #, !, and whitespace are safe, but \, " (did you miss that on purpose?), <, >, *, and ? are not. > +# skip if we cannot create such a file or directory > +AT_CHECK([mkdir "$dir" "$cachedir" "$TMPDIR" && test -f "$file.m4" || exit > 77]) Unrelated to your patch series, but I'm wondering if we should provide AT_SKIP or AT_SKIP_IF that uses the file system to record skips, so that you can expand such a macro regardless of how many subshells you are nested in, and not have to worry about exit status 77 propagating all the way out to the test engine. On the other hand, I know the tar testsuite already defines its own AT_SKIP. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHVqY284KuGfSFAYARAvZAAJ4p2f+vcjHVcdYn71LNI55jrkNRawCeMHHP I+fmZGvL1vPaSQP5qbJ6r8w= =Svjk -----END PGP SIGNATURE-----
