Hi Jim,
* Jim Meyering wrote on Fri, Dec 07, 2007 at 08:49:25AM CET:
> Ralf Wildenhues <[EMAIL PROTECTED]> wrote:
[...]
> > --- a/tests/torture.at
> > +++ b/tests/torture.at
> > @@ -973,9 +973,9 @@ AT_DATA([configure.ac],
> > AC_CONFIG_FILES([foo at-dir/bar])
> >
> > AC_CONFIG_COMMANDS([report],
> > -[test -f $srcdir/configure.ac ||
> > +[test -f "$srcdir/configure.ac" ||
> > AC_MSG_ERROR([cannot find $srcdir/configure.ac])],
> > - [srcdir=$srcdir])
> > + [srcdir='$srcdir'])
[...]
> At first, I thought using single quotes here might be a mistake.
> Of course, once I looked at a generated configure script, it
> makes sense: that's part of an unquoted here document.
>
> How about adding a comment like this?
Thanks, will apply as below (for looks, I used # comments rather than
d@&[EMAIL PROTECTED] escaped ones).
Cheers,
Ralf
diff --git a/tests/torture.at b/tests/torture.at
index 11c619d..6a7b962 100644
--- a/tests/torture.at
+++ b/tests/torture.at
@@ -972,10 +972,13 @@ AT_DATA([configure.ac],
AC_CONFIG_FILES([foo at-dir/bar])
+# Use quotes in the INIT-COMMANDS to accommodate a value of $srcdir
+# containing e.g., spaces or shell meta-characters.
+# Use *single* quotes because the context is an unquoted here-doc.
AC_CONFIG_COMMANDS([report],
-[test -f $srcdir/configure.ac ||
+[test -f "$srcdir/configure.ac" ||
AC_MSG_ERROR([cannot find $srcdir/configure.ac])],
- [srcdir=$srcdir])
+ [srcdir='$srcdir'])
AC_OUTPUT
rm -f -r foo at-dir/bar
