Hi Paul,
Happy new year :)
On Jan 3, 2008, at 1:16 AM, Paul Eggert wrote:
Thanks for those three patches (in
<http://lists.gnu.org/archive/html/autoconf-patches/2007-12/
msg00070.html>,
<http://lists.gnu.org/archive/html/autoconf-patches/2007-12/
msg00069.html>,
<http://lists.gnu.org/archive/html/autoconf-patches/2007-12/
msg00071.html>).
I assume the 3rd patch is still experimental and not meant to be
installed
yet. In reviewing the first two I see a minor issue:
+# Neutralize special characters interpreted by sed in replacement
strings.
+case $configure_input in #(
+ *'&'*) ac_sed_conf_input=`AS_ECHO(["$configure_input"]) |
+ sed 's/\\\\/\\\\\\\\/g;s/&/\\\\\\&/
g'`;; #(
I'm a bit lost here, but shouldn't this check for \ in
$configure_input as well?
Nope, since $configure_input is used to expand @configure_input@
which would lead to file containing a message saying "<file-name-
escaped>. Generated from <file-name-escaped>.in" rather than "<file-
name>. Generated from <file-name>.in". It's not really a bug but
it's not what users want, or so I think. When I first implemented
this patch, I escaped $configure_input and stumbled on this oddity,
hence the more awkward fix. Besides, I adjusted the test suite so
that it check that the proper names are used when expanding
@[EMAIL PROTECTED]
Also, wouldn't the last line be a bit
simpler as:
sed 's/[[\\\\&]]/\\\\&/g'`;; #(
Yes, of course, thanks!
--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory
