Ralf Wildenhues <[EMAIL PROTECTED]> wrote:
> * Jim Meyering wrote on Sun, Mar 02, 2008 at 05:39:07PM CET:
>> I noticed that "make dist" would infloop.
>> This change fixes that and syncs the pieces
>> from coreutils and gnulib:
>>
>> Don't infloop upon "make dist".
>> * GNUmakefile: Merge from coreutils.
>> * Makefile.am (dist-hook): Inject .tarball-version into tarball,
>> not .version.
>> * configure.ac (AC_INIT): Use .tarball-version, not .version.
>> * build-aux/git-version-gen: Update from gnulib.
>>
>> Ok to commit?
>
> Can you explain the infloop to me, because I have not experienced such
> a loop. Is that because I do not build in-tree?
Perhaps. That's the only way I've seen it.
Try it in a srcdir build and you'll see for yourself.
> Note that I do have
> symlinks $builddir/GNUmakefile -> $srcdir/GNUmakefile and similar for
> Makefile.maint. Without your patch, I get
...
>> -# Copyright (C) 2001, 2003, 2006-2007 Free Software Foundation, Inc.
>> +# Copyright (C) 2001, 2003, 2006-2008 Free Software Foundation, Inc.
>
> Please don't add ranges, but individual years, comma-separated.
Yes, I know what GCS, lawyers, etc. prefer.
Let's not worry about it. I'm just syncing from coreutils.
If it's a show-stopper for you, I'll change it in autoconf
(but not in coreutils).
>> # This program is free software: you can redistribute it and/or modify
>> # it under the terms of the GNU General Public License as published by
>> # the Free Software Foundation, either version 3 of the License, or
>> # (at your option) any later version.
>> -#
>> +
>
> What's this good for except possibly interfering with a later scripted
> change of many files' copyright statements (two instances)?
Simply sync'd from coreutils. I don't care.
Which way would you like?
>> + $(info INFO: running autoreconf for new version string: $(_curr-ver))
>> + _dummy := $(shell \
>> rm -rf autom4te.cache; \
>> (cd $(srcdir) && autoreconf -i -v) \
>> && rm -f INSTALL)
>
> Actually, this autoreconf invocation should have $build_tree/tests as
> first $PATH entry, so that in-tree auto* are used if present. I'm not
Yes, we've been through this already :)
You mean the ones that are used according to this PATH setting
at the top of that file?
# Build with our own versions of these tools, when possible.
export PATH = $(shell echo "`pwd`/tests:$$PATH")
> sure if I really want this, because in order to be consistent, all other
> rebuilding rules in all Makefiles should then be overridden as well, but
> it'd be The Right Thing. Hmm.
