-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Ralf Wildenhues on 7/16/2008 1:11 PM: | > Should I go ahead and revert my addition of m4_prepend altogether | Reverting is fine with me.
OK, I'll commit a reversion patch shortly. |> m4_define([m4_version_prereq], |> -[m4_if(m4_version_compare(]m4_dquote(m4_defn([m4_PACKAGE_VERSION]))[, [$1]), |> - [-1], |> - [m4_default([$3], |> - [m4_fatal([Autoconf version $1 or higher is required], |> - [63])])], |> - [$2])]) |> +m4_ifdef([m4_PACKAGE_VERSION], |> +[[m4_if(m4_version_compare(]m4_dquote(m4_defn([m4_PACKAGE_VERSION]))[, [$1]), | | That's overquoted, no? How can this work as intended? (untested) Nope. It's because it is inside an unquoted m4_ifdef, where the result of the m4_ifdef must be quoted, so that the overall argument handed to m4_define is single quoted rather than executed early. Trust me - I coded it the wrong way first (one quote instead of two), and did a double take when bison was still complaining about m4_defn dereferencing undefined m4_PACKAGE_VERSION. - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkh+UykACgkQ84KuGfSFAYCsIQCfQAO99+ZfSw64NjpmxuTo6w4U 1wEAn3uiELyCBb27xxWDiEAI/6LJ2lLX =Dtxj -----END PGP SIGNATURE-----
