Hi Eric, * Eric Blake wrote on Thu, Aug 14, 2008 at 11:15:19PM CEST: > Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes: > > > The bit fixing most of the issues you reported is the missing '$' in > > AC_CHECK_TARGET_TOOL. I think the macros are wrong in warning about a > > previous AC_CANONICAL_TARGET, however. Shouldn't it rather be that they > > should require it? > > Thanks for the analysis, and yes, I agree that an AC_REQUIRE is correct > (AC_BEFORE implies that the use of AC_CANONICAL_TARGET is optional albeit > ordering-constrained; but in the case of checking target tools, > AC_CANONICAL_TARGET is not optional).
Not only that: the ordering constraint implied by the AC_BEFORE was plain wrong: it warned if AC_CANONICAL_TARGET was used before AC_CHECK_TARGET_TOOL. > Wow, that missing $ has gone undetected > for quite some time: since its intruduction in 2004 (per commit e09a76, as > found in less than half a second by > $ git log -S'=ac_c' lib/autoconf/programs.m4 > Have I ever mentioned how much I like git? That sort of historical analysis > is > very time-consuming in CVS). Yep, I've come to appreciate that as well. > > OK to apply? > > Yes; Thanks for the quick review, pushed. Cheers, Ralf
