Hi, > Paolo Bonzini writes: > > > > This patch documents $as_me and $LINENO, which are the sole constructs > > (for now) that explicitly require a *_PREPARE macro because they are > > variables. So those are defined without the hyphen and documented.
How about also adding tests for them? Anything that is documented (and most stuff that is undocumented) but not explicitly tested basically has to be assumed to be broken. As a really really minor nit, I noted that commit logs use a bit different styles. I'm not sure whether it's worth making a fuss of it, but I'd volunteer writing a script to convert from ChangeLog entries to commit log entries if that helps. In fact, I think this is a good first approximation (note embedded TAB): git diff HEAD ChangeLog | sed -n '/^+$/,$s/^+ //p' | sed '1a\ ' Cheers, Ralf
