-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Paolo Bonzini on 10/15/2008 5:32 AM: > With this patch, the better-shell loop is always executed, even if > it is a no-op. Unfortunately I could not find a better way to > make things go in the appropriate diversion for both "correct" > scripts and Libtool scripts. However, the next patch will anyway > add a test that is always executed (in order to find a shell with > functions and unset), so this pessimization is only temporary.
I thought that all shells with functions also have unset, per the history of bourne shell page referred to earlier. > > Isolating the parts of AS_INIT that should be included in Libtool > required some surgery; the main problem, of course, is that > AS_SHELL_SANITIZE could be called in two different contexts: in > Libtoolize as part of a toplevel script, and in Libtool as part > of the creation of config.lt. However, overall I like the code > better (with the exception of the new AS_SHELL_SANITIZE macro). Well, backwards compatibility can be gross. As a followup patch, we should also massage the manual to move AS_SHELL_SANITIZE into the node on obsolete macros, and NEWS to mention that new scripts should not invoke it (AS_INIT is sufficient). But that doesn't stop checking in this patch; please commit, with this nit addressed. > -[_AS_DETECT_REQUIRED([_AS_SHELL_FN_WORK])dnl > +[AS_DETECT_REQUIRED([_AS_SHELL_FN_WORK])dnl Did I miss where you created AS_DETECT_REQUIRED? - -- Don't work too hard, make some time for fun as well! Eric Blake [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkj16q4ACgkQ84KuGfSFAYCcngCeJLFGbF7gdWbgctuLn8cAsTL0 sNQAnRpg0JWarQv82fyGFHDTsMcYmriV =wntt -----END PGP SIGNATURE-----
